[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 08/45] Return path: socket_writev_buffer: Blo
|
From: |
Dr. David Alan Gilbert |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 08/45] Return path: socket_writev_buffer: Block even on non-blocking fd's |
|
Date: |
Mon, 30 Mar 2015 17:50:43 +0100 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
* Paolo Bonzini (address@hidden) wrote:
>
>
> On 29/03/2015 06:07, David Gibson wrote:
> > On Sat, Mar 28, 2015 at 04:30:06PM +0100, Paolo Bonzini wrote:
> >>
> >>
> >> On 25/02/2015 17:51, Dr. David Alan Gilbert (git) wrote:
> >>> + if (err != EAGAIN) {
> >>
> >> if (err != EAGAIN && err != EWOULDBLOCK)
> >
> > I assume that's for the benefit of non-Linux hosts? On Linux
> > EAGAIN == EWOULDBLOCK.
>
> Yes, that's just the standard idiom in QEMU. This is generic code, so
> assumption based on the host platform are not wise. :)
Done; I didn't know of EWOULDBLOCK - and indeed as far as I can tell
most places we only test for EAGAIN.
>
> Paolo
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK