[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/6] target-ppc: Convert PReP to machine class
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 4/6] target-ppc: Convert PReP to machine class |
Date: |
Mon, 30 Mar 2015 23:33:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
Am 06.03.2015 um 05:18 schrieb David Gibson:
> The more commonly used ppc machine types: spapr, and newworld Mac have
> already been converted to the newer MachineClass representation, but some
> others still use QEMUMachine.
>
> This patch cleans things up slightly, by converting the "prep" machine
> type to the new style.
>
> Signed-off-by: David Gibson <address@hidden>
> ---
> hw/ppc/prep.c | 30 +++++++++++++++++++++---------
> 1 file changed, 21 insertions(+), 9 deletions(-)
>
> diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
> index 15df7f3..dfc8689 100644
> --- a/hw/ppc/prep.c
> +++ b/hw/ppc/prep.c
> @@ -44,6 +44,8 @@
> #include "exec/address-spaces.h"
> #include "elf.h"
>
> +#define TYPE_PREP_MACHINE "PReP-machine"
[snip]
qemu_register_machine() generated the type name by concatenating
QEMUMachine::name with "-machine", so this should be "prep-machine".
Otherwise looks great.
Thanks,
Andreas
- [Qemu-devel] [PATCH 6/6] Allow ISA bus to be configured out, (continued)
- [Qemu-devel] [PATCH 1/6] Split serial-isa into its own config option, David Gibson, 2015/03/05
- [Qemu-devel] [PATCH 4/6] target-ppc: Convert PReP to machine class, David Gibson, 2015/03/05
- Re: [Qemu-devel] [PATCH 4/6] target-ppc: Convert PReP to machine class,
Andreas Färber <=
- [Qemu-devel] [PATCH 3/6] pc: Use MachineClass callbacks for "irq" and "pic" hmp commands, David Gibson, 2015/03/05
- Re: [Qemu-devel] [PATCH 0/6] Clean up ISA dependencies so we make ISA optional to build, Alexander Graf, 2015/03/06
- Re: [Qemu-devel] [PATCH 0/6] Clean up ISA dependencies so we make ISA optional to build, Michael S. Tsirkin, 2015/03/10