[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests |
Date: |
Mon, 30 Mar 2015 16:45:21 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 03/26/2015 09:58 AM, Markus Armbruster wrote:
>>> /home/armbru/work/qemu/.git/rebase-apply/patch:325: new blank line at EOF.
>>
>> Huh. I thought I had git set up to reject me from making commits like
>> that locally, but obviously not.
>
> There's another one in PATCH 13:
>
> /home/armbru/work/qemu/.git/rebase-apply/patch:156: new blank line at EOF.
>
>> http://wiki.qemu.org/Contribute/SubmitAPatch should probably mention the
>> magic one-time setup to use to turn this type of checking on...
>
> Feel free to add it :)
The wiki already mentions how:
*
[http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.html
Automate a checkpatch run on commit]
but I had failed to 'chmod +x .git/hooks/pre-commit' to actually use it.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests, (continued)
- Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests, Kevin Wolf, 2015/03/31
- Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests, Eric Blake, 2015/03/31
- Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests, Eric Blake, 2015/03/31
- Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests, Kevin Wolf, 2015/03/31
- Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests, Markus Armbruster, 2015/03/31
Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests, Markus Armbruster, 2015/03/26
[Qemu-devel] [PATCH v5 26/28] qapi: Drop inline nested type in query-version, Eric Blake, 2015/03/24
[Qemu-devel] [PATCH v5 22/28] qapi: Whitelist commands that don't return dictionary, Eric Blake, 2015/03/24
[Qemu-devel] [PATCH v5 23/28] qapi: More rigorous checking for type safety bypass, Eric Blake, 2015/03/24