qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 17/28] qapi: Allow true, false and null in sc


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH v5 17/28] qapi: Allow true, false and null in schema json
Date: Tue, 31 Mar 2015 17:23:59 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 24.03.2015 um 21:03 hat Eric Blake geschrieben:
> From: Fam Zheng <address@hidden>
> 
> In the near term, we will use it for a sensible-looking
> 'gen':false inside command declarations, instead of the
> current ugly 'gen':'no'.
> 
> In the long term, it will allow conversion from shorthand
> with defaults mentioned only in side-band documentation:
>  'data':{'*flag':'bool', '*string':'str'}
> into an explicit default value documentation, as in:
>  'data':{'flag':{'type':'bool', 'optional':true, 'default':true},
>          'string':{'type':'str', 'optional':true, 'default':null}}

FWIW, I don't think that's a very friendly syntax for humans, it's a bit
verbose. But that's no reason not to allow true/false/null, of course.

> We still don't parse integer values (also necessary before
> we can allow explicit defaults), but that can come in a later
> series.
> 
> Update the testsuite to match an improved error message.
> 
> Signed-off-by: Fam Zheng <address@hidden>
> Signed-off-by: Eric Blake <address@hidden>

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]