[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qga/commands-posix: Fix bug in guest-fstrim
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] qga/commands-posix: Fix bug in guest-fstrim |
|
Date: |
Tue, 31 Mar 2015 11:03:27 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 03/31/2015 10:52 AM, Paolo Bonzini wrote:
>> -# Returns: Nothing.
>> +# Returns: Number of bytes trimmed by this call.
>
> It's better to add "(since 2.4)" here.
>
> Apart from this, looks good.
Changing a "return":{} to "return":0 is not backwards-compatible.
>
> I'm CCing the qemu-ga maintainer.
I failed to do that in my beefier reply, so I'm responding here just to
say that this needs a v2.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature