Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

[John Snow]

On 03/31/2015 05:55 PM, Ed Maste wrote:
> On 31 March 2015 at 17:44, John Snow <address@hidden> wrote:
> > My apologies;
>
> Not at all, thanks for your help!
>
> > Head into your build directory and try this:
> >
> > > make tests/ahci-test
> > > export QTEST_QEMU_BINARY=i386-softmmu/qemu-system-i386
> > > export QTEST_QEMU_IMG=./qemu-img
> > > ./tests/ahci-test
> >
> > This should show you which test in particular is failing. I have a hunch it
> > will be the PIO, again...
>
> Correct:
>
> feynman% ./tests/ahci-test
> /i386/ahci/sanity: OK
> /i386/ahci/pci_spec: OK
> /i386/ahci/pci_enable: OK
> /i386/ahci/hba_spec: OK
> /i386/ahci/hba_enable: OK
> /i386/ahci/identify: OK
> /i386/ahci/io/pio/lba28/simple: **
> ERROR:tests/ahci-test.c:790:ahci_test_io_rw_simple: assertion failed
> (memcmp(tx, rx, bufsize) == 0): (0xffffffffffffffff == 0x00000000)
> zsh: abort (core dumped)  ./tests/ahci-test
>
> > In the meantime, what is your setup? which release, what architecture?
>
> This is the FreeBSD stable/10 branch on amd64 (so part way between
> 10.1 and what will become 10.2):
>
> FreeBSD feynman 10.1-STABLE FreeBSD 10.1-STABLE #28
> r280427+86df2de(stable-10): Thu Mar 26 16:07:47 EDT 2015
> address@hidden:/tank/emaste/obj/tank/emaste/src/git-stable-10/sys/GENERIC
>   amd64

Thanks, one more if you have the spare cycles; and then I'll go prepare 
a machine to debug for myself.

./ahci-test -p /i386/ahci/io/pio/lba28/short
./ahci-test -p /i386/ahci/io/pio/lba48/short

quite likely both work for you, while changing short for "simple" "long" 
or "double" probably all fail.

./ahci-test -p /i386/ahci/io/dma/

probably launches a series of tests that also all work correctly.

Thank you for your help,
--John