Re: [Qemu-devel] [PATCH 6/7] throttle: add the name of the ThrottleGroup to BlockDeviceInfo

[Fam Zheng]

On Wed, 04/01 12:06, Alberto Garcia wrote:
> On Wed, Apr 01, 2015 at 05:59:40PM +0800, Fam Zheng wrote:
> 
> > >          info->has_iops_size = cfg.op_size;
> > >          info->iops_size = cfg.op_size;
> > > +
> > > +        info->has_group = true;
> > > +        info->group = g_strdup(throttle_group_get_name(bs));
> > 
> > True even if it's unset?
> 
> Note that that's inside an "if (bs->io_limits_enabled)" block.

Then this is OK :)

Fam

> 
> io_limits_enabled is set immediately after adding a BDS to a
> throttling group, and that requires a name.
> 
> > > +# @group: #optional throttle group name (Since 2.3)
> > 
> > Will probably be 2.4.
> 
> Right.
> 
> Berto