Re: [Qemu-devel] [PATCH] hw/arm/virt: Fix corruption due to double free

[Peter Maydell]

On 2 April 2015 at 04:07, Shannon Zhao <address@hidden> wrote:
> From: Shannon Zhao <address@hidden>
>
> As 4de9a88(hw/arm/virt: Fix memory leak reported by Coverity)
> and 6e05a12(arm: fix memory leak) both handle the memory leak
> reported by Coverity, this cause qemu corruption due to
> double free.
>
> Signed-off-by: Shannon Zhao <address@hidden>
> Signed-off-by: Shannon Zhao <address@hidden>
> ---
>  hw/arm/virt.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 7d082e2..febff22 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -572,7 +572,6 @@ static void create_flash(const VirtBoardInfo *vbi)
>              error_report("Could not load ROM image '%s'", bios_name);
>              exit(1);
>          }
> -        g_free(fn);
>      }
>
>      create_one_flash("virt.flash0", flashbase, flashsize);

Oops, yes. vexpress.c has the same double-free too.

-- PMM