[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH COLO v3 11/14] Backup: clear all bitmap when doing b
From: |
Wen Congyang |
Subject: |
[Qemu-devel] [PATCH COLO v3 11/14] Backup: clear all bitmap when doing block checkpoint |
Date: |
Fri, 3 Apr 2015 18:01:17 +0800 |
Signed-off-by: Wen Congyang <address@hidden>
Signed-off-by: zhanghailiang <address@hidden>
Signed-off-by: Gonglei <address@hidden>
Cc: Jeff Cody <address@hidden>
---
block/backup.c | 13 +++++++++++++
blockjob.c | 10 ++++++++++
include/block/blockjob.h | 12 ++++++++++++
3 files changed, 35 insertions(+)
diff --git a/block/backup.c b/block/backup.c
index 1c535b1..e8b8931 100644
--- a/block/backup.c
+++ b/block/backup.c
@@ -208,11 +208,24 @@ static void backup_iostatus_reset(BlockJob *job)
bdrv_iostatus_reset(s->target);
}
+static void backup_do_checkpoint(BlockJob *job, Error **errp)
+{
+ BackupBlockJob *backup_job = container_of(job, BackupBlockJob, common);
+
+ if (backup_job->sync_mode != MIRROR_SYNC_MODE_NONE) {
+ error_setg(errp, "this feature or command is not currently supported");
+ return;
+ }
+
+ hbitmap_reset_all(backup_job->bitmap);
+}
+
static const BlockJobDriver backup_job_driver = {
.instance_size = sizeof(BackupBlockJob),
.job_type = BLOCK_JOB_TYPE_BACKUP,
.set_speed = backup_set_speed,
.iostatus_reset = backup_iostatus_reset,
+ .do_checkpoint = backup_do_checkpoint,
};
static BlockErrorAction backup_error_action(BackupBlockJob *job,
diff --git a/blockjob.c b/blockjob.c
index ba2255d..dbac81e 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -388,3 +388,13 @@ void block_job_defer_to_main_loop(BlockJob *job,
qemu_bh_schedule(data->bh);
}
+
+void block_job_do_checkpoint(BlockJob *job, Error **errp)
+{
+ if (!job->driver->do_checkpoint) {
+ error_setg(errp, "this feature or command is not currently supported");
+ return;
+ }
+
+ job->driver->do_checkpoint(job, errp);
+}
diff --git a/include/block/blockjob.h b/include/block/blockjob.h
index b6d4ebb..c6f1cad 100644
--- a/include/block/blockjob.h
+++ b/include/block/blockjob.h
@@ -50,6 +50,9 @@ typedef struct BlockJobDriver {
* manually.
*/
void (*complete)(BlockJob *job, Error **errp);
+
+ /** Optional callback for job types that support checkpoint. */
+ void (*do_checkpoint)(BlockJob *job, Error **errp);
} BlockJobDriver;
/**
@@ -334,4 +337,13 @@ void block_job_defer_to_main_loop(BlockJob *job,
BlockJobDeferToMainLoopFn *fn,
void *opaque);
+/**
+ * block_job_do_checkpoint:
+ * @job: The job.
+ * @errp: Error object.
+ *
+ * Do block checkpoint on the specified job.
+ */
+void block_job_do_checkpoint(BlockJob *job, Error **errp);
+
#endif
--
2.1.0
- [Qemu-devel] [PATCH COLO v3 06/14] NBD client: implement block driver interfaces for block replication, (continued)
- [Qemu-devel] [PATCH COLO v3 06/14] NBD client: implement block driver interfaces for block replication, Wen Congyang, 2015/04/03
- [Qemu-devel] [PATCH COLO v3 05/14] quorum: implement block driver interfaces for block replication, Wen Congyang, 2015/04/03
- [Qemu-devel] [PATCH COLO v3 04/14] Add new block driver interfaces to control block replication, Wen Congyang, 2015/04/03
- [Qemu-devel] [PATCH COLO v3 07/14] allow writing to the backing file, Wen Congyang, 2015/04/03
- [Qemu-devel] [PATCH COLO v3 03/14] NBD client: connect to nbd server later, Wen Congyang, 2015/04/03
- [Qemu-devel] [PATCH COLO v3 08/14] Allow creating backup jobs when opening BDS, Wen Congyang, 2015/04/03
- [Qemu-devel] [PATCH COLO v3 10/14] util/hbitmap: Add an API to reset all set bits in hbitmap, Wen Congyang, 2015/04/03
- [Qemu-devel] [PATCH COLO v3 11/14] Backup: clear all bitmap when doing block checkpoint,
Wen Congyang <=
- [Qemu-devel] [PATCH COLO v3 09/14] block: Parse "backing_reference" option to reference existing BDS, Wen Congyang, 2015/04/03
- [Qemu-devel] [PATCH COLO v3 14/14] Don't allow a disk use backing reference target, Wen Congyang, 2015/04/03
- [Qemu-devel] [PATCH COLO v3 12/14] qcow2: support colo, Wen Congyang, 2015/04/03
- [Qemu-devel] [PATCH COLO v3 13/14] skip nbd_target when starting block replication, Wen Congyang, 2015/04/03