qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qtest: Add assertion that required environment


From: John Snow
Subject: Re: [Qemu-devel] [PATCH] qtest: Add assertion that required environment variable is set
Date: Mon, 06 Apr 2015 13:46:15 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0



On 04/03/2015 07:18 AM, Peter Maydell wrote:
On 2 April 2015 at 20:31, Ed Maste <address@hidden> wrote:
On 1 April 2015 at 18:45, Peter Maydell <address@hidden> wrote:
Also irritating is the way it silently requires
the binary to have a name in the shape it was
expecting, which can catch you out if you were
trying to set it to a wrapper shell script that
invokes valgrind or something...

I don't really have enough context to propose a good user-facing
message with a tip for manually executing this, so hopefully someone
else can provide one. I just noticed one other instance that already
had an assertion on getenv("QTEST_QEMU_BINARY") being non-null.

Yes, that was just me venting about something that caught me
out in the past rather than review comment on this patch :-)
Sorry for any confusion.

-- PMM


I'll pull this into ide-next for 2.4 -- I have some ahci-test things to submit anyway.

I'll touch up the user facing error messages in a later patch and hit a few of the startup assertions all at once.

Thanks.
--js



reply via email to

[Prev in Thread] Current Thread [Next in Thread]