Re: [Qemu-devel] [PATCH] PING - add 1394 support

[Andreas Färber]

Hi,

Am 07.04.2015 um 10:18 schrieb Itamar Tal:
> Hi,
> 
> Haven't got any response to this patch and couldn't find relevant
> maintainer as well. Can anyone direct me to the right guy?
> 
> Thanks,
> 
> Itamar Tal,
> Guardicore
> 
> On Mon, Mar 23, 2015 at 6:07 PM, Itamar Tal <address@hidden
> <mailto:address@hidden>> wrote:
> 
>     From 9c4425d4145ac6b0a2d19a6fdf5803dd13f1fa93 Mon Sep 17 00:00:00 2001
>     From: Itamar Tal <address@hidden <mailto:address@hidden>>
>     Date: Mon, 23 Mar 2015 14:26:47 +0200
>     Subject: [PATCH] add 1394 support
> 
>     This patch add 1394 (firewire) support to x86_64 and i386 qemu
>     softmmu. It allows one virtual machine to be the server side and the
>     other to be the client side, connected by TCP stream socket (same
>     thing is possible using serial port). This is very useful in for
>     allowing legacy devices to communicate over the firewire channel, but
>     doesn't support USB communication. Especially, it's useful for remote
>     Windows kernel debugging over qemu for malware analysis and so on...
>     The patch was tested on major stable version 2.0.0, 2.2.1 and current
>     master (2.3.0rc?).
> 
>     Itamar Tal,
>     Guardicore
> 
>     ---
>      hw/1394/Makefile.objs |    7 +
>      hw/1394/hcd-ohci.c    | 1645
>     +++++++++++++++++++++++++++++++++++++++++++++++++
>      hw/1394/hcd-ohci.h    |  147 +++++
>      hw/Makefile.objs      |    1 +
>      4 files changed, 1800 insertions(+)
>      create mode 100644 hw/1394/Makefile.objs
>      create mode 100644 hw/1394/hcd-ohci.c
>      create mode 100644 hw/1394/hcd-ohci.h
[snip]

Somehow this message does not appear threaded to such a patch...

Don't top-post. Don't use HTML mails. Read SubmittingPatches - it
specifically states that we cannot accept patches that are not signed
off. Also, your commit message needs to be overhauled, and the patch did
not arrive the right way - looks like you did not use git-send-email but
instead pasted a patch file into an email, which caused linewrap damage
and wrongly added the headers into what would be the commit message.
Information on where/how the patch was tested and your name/company
belongs below --- or into a separate (threaded!) cover letter, not into
the commit message.

Since you're implementing a new bus, there is no predefined maintainer
to review this... and as long as we're in Hard Freeze for v2.3 review
may take some time.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)