qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH qemu v5 05/12] vfio: spapr: Move SPAPR-related c


From: David Gibson
Subject: Re: [Qemu-devel] [PATCH qemu v5 05/12] vfio: spapr: Move SPAPR-related code to a separate file
Date: Wed, 8 Apr 2015 12:05:10 +1000
User-agent: Mutt/1.5.23 (2014-03-12)

On Tue, Mar 31, 2015 at 04:28:40PM +1100, Alexey Kardashevskiy wrote:
> This moves SPAPR bits to a separate file to avoid pollution of x86 code.
> 
> This is a mechanical patch.
> 
> Signed-off-by: Alexey Kardashevskiy <address@hidden>

Reviewed-by: David Gibson <address@hidden>

Splitting out the iommu mode specific code seems sensible to me.  A
bunch of the functions that have moved look as if they're not
inherently spapr specific - it's just that spapr is the only user so
far.  But I guess they can be moved back to common.c when and if
another user comes along.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: pgp5wIkF2TkzP.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]