qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] configure: improve multiarch support for pkgcon


From: John Snow
Subject: Re: [Qemu-devel] [PATCH] configure: improve multiarch support for pkgconfig
Date: Fri, 10 Apr 2015 10:15:36 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0



On 04/10/2015 09:59 AM, Gerd Hoffmann wrote:
   Hi,

32-bit compilation on 64-bit hosts is broken because pkgconfig isn't
multi-arch aware and selects the 64-bit glibconfig.h header file.  That
file assumes the LP64 data model so guint64 is defined as unsigned long.
This does not work for 32-bit builds where sizeof(unsigned long) == 4
bytes.

... there are more effects, like stuff being enabled because 64bit devel
lib is installed even when the 32bit devel lib isn't.

IMO it is fine to expect users set PKG_CONFIG_LIBDIR accordingly in that
case.  It would be very nice though to record this variable (in
config.status maybe?) so it doesn't get lost in case make figures it
should re-run configure because it was changed.


I'm not sure I follow you. What would be wrong with configure re-polling for the correct setting in that case?

Unless, perhaps, you are discussing the possibility of losing a user override from the first time they ran configure with PKG_CONFIG_LIBDIR already set to some custom value.

cheers,
   Gerd





reply via email to

[Prev in Thread] Current Thread [Next in Thread]