qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.3] stm32f205: Fix SoC type name


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH for-2.3] stm32f205: Fix SoC type name
Date: Fri, 10 Apr 2015 16:51:47 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

Am 10.04.2015 um 16:47 schrieb Alistair Francis:
> On Sat, Apr 11, 2015 at 12:37 AM, Andreas Färber <address@hidden> wrote:
>> The type name for the SoC device, unlike those of its sub-devices,
>> did not follow the QOM naming conventions. While the usage is internal
>> only, this is exposed through QMP and HMP, so fix it before release.
>>
>> Cc: Alistair Francis <address@hidden>
>> Signed-off-by: Andreas Färber <address@hidden>
> 
> Looks good to me. Sorry about this slipping in, thanks for fixing it.
> 
> Reviewed-by: Alistair Francis <address@hidden>

Thanks. BTW a real SoC device would integrate ARMCPU as well - in that
case we would need to distinguish -arm-soc and -aarch64-soc, like we do
for CPUs.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]