Re: [Qemu-devel] [PATCH v2 3/4] target-i386: Register QOM properties for feature flags

[Eduardo Habkost]

On Fri, Apr 10, 2015 at 10:21:49AM +0200, Paolo Bonzini wrote:
> 
> 
> On 10/04/2015 09:27, Igor Mammedov wrote:
> > > +    for (i = 0; names[i]; i++) {
> > > +        char *feat_name = names[i];
> > > +        feat2prop(feat_name);
> > > +        char *prop_name = g_strdup_printf("cpuid-%s", feat_name);
> > 
> > BTW: I've remembered why we've chosen feat- vs. cpuid- prefix
> > it was to make CPU features platform neutral so that libvirt
> > would use the same prefix for x86, arm other targets.
> 
> Ok, that make sense, but if we want to make it platform-neutral, let's
> spell it "feature-" or remove the prefix altogether.

I am liking the idea of removing the prefix. I can't find a compelling
reason for making boolean properties that affect CPUID special and
different from other boolean properties in X86CPU.

> 
> If we remove it, perhaps we could add a QOM property with the list of
> features?

I am not even sure this will be necessary. libvirt, for example, is
already aware of the list of CPU feature flags it can set/unset, so it
probably wouldn't need the list. If it becomes necessary, we can add it.

I will send v4 without the prefix.

-- 
Eduardo