Re: [Qemu-devel] [PATCH 02/12 v9] linux-user: tilegx: Add target features support within qemu

[Peter Maydell]

On 10 April 2015 at 22:59, Andreas Färber <address@hidden> wrote:
> I know linux-user is a mess. But that does not sound appealing. If this
> is from a generic header, can't we put that in a shared header too and
> #include it from aarch64 and tilegx without duplicating it?

I certainly wouldn't object if somebody wanted to try to
factor out some of our mess of ifdefs to produce something
more like "structs defined in linux-user/$arch/$foo.h, which
might just include linux-user/generic/$foo.h". I'm just not
insisting on it as a blocker for a new target (would be
a bit hypocritical given we didn't do it for aarch64).

This is just one of the many cleanups I'd do in linux-user
if I had 3 to 6 months to spend on refactoring and fixing
it :-)

-- PMM