Re: [Qemu-devel] [PATCH 01/12 v9] linux-user: tilegx: Firstly add architecture related features

[Chen Gang]

On 4/11/15 05:38, Peter Maydell wrote:
> On 10 April 2015 at 21:01, Chen Gang <address@hidden> wrote:
>>
>> Firstly, thank you very much for your patient work for all related
>> patches.
>>
>> And I shall try to send patch v10 within this month, and let linux-user
>> run "Hello world" completely (finish emulate a demo executable binary
>> successfully).
>>
>> The related reply is below:
>>
>> On 4/10/15 05:21, Peter Maydell wrote:
>>>> +    tilegx_reg_t tp;     /* thread-local data */
>>>> +    tilegx_reg_t sp;     /* stack pointer */
>>>> +    tilegx_reg_t lr;     /* lr pointer */
>>>
>>> This is missing a bunch of stuff from the kernel uapi
>>> pt_regs type, which is bad because this struct is part
>>> of the user-facing ABI (it gets used in signal handling).
>>>
>>
>> OK, thanks. And I guess, sigcontext is a little betther than pt_regs.
> 
> sigcontext is a different struct. The target_pt_regs struct
> should match the kernel's pt_regs struct, and the target_sigcontext
> should match the kernel's sigcontext struct.
> 

OK, Thanks.

-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed