[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] virtio-balloon: virtio 1 support
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] virtio-balloon: virtio 1 support |
|
Date: |
Mon, 13 Apr 2015 13:49:42 +0200 |
On Mon, Apr 13, 2015 at 01:35:21PM +0200, Cornelia Huck wrote:
> On Mon, 13 Apr 2015 13:26:31 +0200
> "Michael S. Tsirkin" <address@hidden> wrote:
>
> > On Mon, Apr 13, 2015 at 10:02:58AM +0200, Cornelia Huck wrote:
>
> > > Also, doesn't get_features need to be modified as well so that
> > > VERSION_1 is advertised?
> >
> > virtio_pci_device_plugged seems to set it ATM. I'll re-test to confirm.
>
> Indeed, pci sets it, but ccw does not. And virtio-net, for example,
> sets it explicitly as well. We need to unify this :)
I'm inclined to set it in transport and black-list in specific devices.
--
MST