[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/15] acpi: Add hooks for adding things to the
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 14/15] acpi: Add hooks for adding things to the SSDT table |
|
Date: |
Mon, 13 Apr 2015 15:47:56 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 13/04/2015 13:32, Michael S. Tsirkin wrote:
>>>> So you are suggesting each device add it's own SSDT? I'm not sure how
>>>> that helps debugging, it seems simpler to add it to a common one.
>>>
>>> For example, it's easier to write a unit test: encode something specific
>>> in one of the IDs, then look it up.
>>> Which is, btw, something that's missing in this patchset.
>>
>> A unit test for what?
>
> The ACPI code added. With an extra table it would be easy
> to test that it's there.
Ah, I agree that patch 15 should add something like commit
3a9c86df/71096d6c, but that doesn't need a separate table.
Paolo
[Qemu-devel] [PATCH 05/15] ipmi: Add a local BMC simulation, minyard, 2015/04/07
Re: [Qemu-devel] [PATCH 00/15] IPMI device for qemu, Paolo Bonzini, 2015/04/10