Re: [Qemu-devel] [PATCH for-2.3? 0/7] tests: Fix TCG make test

[Peter Maydell]

On 13 April 2015 at 12:36, Peter Maydell <address@hidden> wrote:
> On 11 April 2015 at 19:34, Andreas Färber <address@hidden> wrote:
>> Hello,
>>
>> In my quest to improve our test coverage, in light of the recent cpu_copy() 
>> breakage,
>> I've taken a stab at make test and actually managed to get most of it to 
>> work on x86_64.
>
> Thanks for tackling this cleanup; to answer the question
> in the subject, I think that at this point in the release
> cycle and given that 'make test' has always been somewhere
> between flaky and broken we should not put this in 2.3.

[summary of a comment from IRC]
Also, even with this patchset it looks like obvious test failures
(eg "reference output differs from actual" and "test segvs")
don't turn into "'make test' returns an error status, so it
doesn't seem to me that "make test" is actually testing
anything usefully at all. I would favour for 2.3 sticking
with our current approach (viz, telling people to use 'make
check', not 'make test'), and for 2.4 trying to integrate
these tests into 'make check', fixing them up in the
process.

thanks
-- PMM