[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.3? 6/7] tests/tcg: Prettify run-runcom out
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH for-2.3? 6/7] tests/tcg: Prettify run-runcom output |
Date: |
Mon, 13 Apr 2015 16:37:53 +0100 |
Andreas Färber <address@hidden> writes:
> Executing the binary pi_10.com terminates without a trailing newline.
>
> As it does not seem to be caused by the runcom program and since we
> can't easily fix pi_10.com, add an echo after executing it. This places
> "make:" output (or that of a target following it) on a new line as expected.
>
> Signed-off-by: Andreas Färber <address@hidden>
> ---
> tests/tcg/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/tcg/Makefile b/tests/tcg/Makefile
> index db8c510..f853d54 100644
> --- a/tests/tcg/Makefile
> +++ b/tests/tcg/Makefile
> @@ -75,6 +75,7 @@ run-test-mmap: test-mmap
>
> run-runcom: runcom
> -$(QEMU) ./runcom $(SRC_PATH)/tests/tcg/pi_10.com
> + @echo
I'm not so sure about this. Shouldn't we be being a lot quieter by
default. At the moment the TCG tests are very noisy with their output
compared to the rest of the tests. On a V=0 run I expect just to see
test name and a PASS/FAIL.
>
> run-test_path: test_path
> ./test_path
--
Alex Bennée
- Re: [Qemu-devel] [PATCH for-2.3? 1/7] tests/tcg: Fix test_path build, (continued)
- [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default, Andreas Färber, 2015/04/11
- Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default, Peter Maydell, 2015/04/11
- Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default, Andreas Färber, 2015/04/11
- Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default, Peter Maydell, 2015/04/11
- Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default, Andreas Färber, 2015/04/11
- Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default, Alexander Graf, 2015/04/12
- Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default, Andreas Färber, 2015/04/12
- Re: [Qemu-devel] [PATCH for-2.3? 7/7] tests/tcg: Enable runcom test by default, Peter Maydell, 2015/04/12
[Qemu-devel] [PATCH for-2.3? 6/7] tests/tcg: Prettify run-runcom output, Andreas Färber, 2015/04/11
- Re: [Qemu-devel] [PATCH for-2.3? 6/7] tests/tcg: Prettify run-runcom output,
Alex Bennée <=
[Qemu-devel] [PATCH for-2.3? 5/7] tests/tcg: Fix run-runcom target, Andreas Färber, 2015/04/11
Re: [Qemu-devel] [PATCH for-2.3? 0/7] tests: Fix TCG make test, Peter Maydell, 2015/04/13