Re: [Qemu-devel] [PATCH RFC 16/19] qobject: Clean up around qtype_code

[Eric Blake]

On 04/02/2015 11:29 AM, Markus Armbruster wrote:
> QTYPE_NONE is a sentinel value.  No QObject has this type code.
> Document it properly.
> 
> Fix dump_qobject() to abort() on QTYPE_NONE, just like for any other
> invalid type code.
> 
> Fix to_json() to abort() on all invalid type codes, not just
> QTYPE_MAX.
> 
> Clean up Property member qtype's type: it's a qtype_code.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  block/qapi.c               | 3 ---
>  include/hw/qdev-core.h     | 2 +-
>  include/qapi/qmp/qobject.h | 2 +-
>  qobject/qjson.c            | 3 +--
>  4 files changed, 3 insertions(+), 7 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature