Re: [Qemu-devel] [v7 12/14] migration: Use an array instead of 3 parameters

[Eric Blake]

On 04/08/2015 12:20 AM, Liang Li wrote:
> Put the three parameters related to multiple thread (de)compression
> into an int array, and use an enum type to index the parameter.
> 
> Signed-off-by: Liang Li <address@hidden>
> Signed-off-by: Yang Zhang <address@hidden>
> ---
>  include/migration/migration.h |  4 +---
>  migration/migration.c         | 31 +++++++++++++++++++------------
>  qapi-schema.json              | 23 +++++++++++++++++++++++
>  3 files changed, 43 insertions(+), 15 deletions(-)
> 

> +++ b/qapi-schema.json
> @@ -569,6 +569,29 @@
>  ##
>  { 'command': 'query-migrate-capabilities', 'returns':   
> ['MigrationCapabilityStatus']}
>  
> +# @MigrationParameter
> +#
> +# Migration parameters enumeration
> +#
> +# @compress-level: Set the compression level to be used in live migration,
> +#          the compression level is an integer between 0 and 9, where 0 means
> +#          no compression, 1 means the best compression speed, and 9 means 
> best
> +#          compression ratio which will consume more CPU.
> +#
> +# @compress-threads: Set compression thread count to be used in live 
> migration,
> +#          the compression thread count is an integer between 1 and 255.
> +#
> +# @decompress-threads: Set decompression thread count to be used in live
> +#          migration, the decompression thread count is an integer between 1
> +#          and 255. Usually, decompression is at least 4 times as fast as
> +#          compression, so set the decompress-threads to the number about 1/4
> +#          of compress-threads is adequate.

s/so set/so setting/

> +#
> +# Since: 2.3

2.4

Maintainer can fix if a respin is not needed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature