Re: [Qemu-devel] [PATCH qemu v6 04/15] vfio: spapr: Move SPAPR-related code to a separate file

[Alexey Kardashevskiy]

On 04/16/2015 05:50 PM, Thomas Huth wrote:
> Am Sat, 11 Apr 2015 01:24:33 +1000
> schrieb Alexey Kardashevskiy <address@hidden>:
>
> > This moves SPAPR bits to a separate file to avoid pollution of x86 code.
> >
> > This is a mechanical patch.
> >
> > Signed-off-by: Alexey Kardashevskiy <address@hidden>
> > Reviewed-by: David Gibson <address@hidden>
> > ---
> >   hw/vfio/Makefile.objs         |   1 +
> >   hw/vfio/common.c              | 134 ++-----------------------
> >   hw/vfio/spapr.c               | 226 ++++++++++++++++++++++++++++++++++++++++++
> >   include/hw/vfio/vfio-common.h |  13 +++
> >   4 files changed, 246 insertions(+), 128 deletions(-)
> >   create mode 100644 hw/vfio/spapr.c
> >
> > diff --git a/hw/vfio/Makefile.objs b/hw/vfio/Makefile.objs
> > index e31f30e..b987ffb 100644
> > --- a/hw/vfio/Makefile.objs
> > +++ b/hw/vfio/Makefile.objs
> > @@ -1,4 +1,5 @@
> >   ifeq ($(CONFIG_LINUX), y)
> >   obj-$(CONFIG_SOFTMMU) += common.o
> >   obj-$(CONFIG_PCI) += pci.o
> > +obj-$(CONFIG_SOFTMMU) += spapr.o
>
> Would it be possible / make sense to use CONFIG_PSERIES instead of
> CONFIG_SOFTMMU here instead?

No. This file has some exports and CONFIG_PSERIES is only for makefiles, 
the source code does not get to see these config options so it is 
impossible to define extern symbols and stubs.



--
Alexey