[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/22] display: enable DIRTY_MEMORY_VGA tracking
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 04/22] display: enable DIRTY_MEMORY_VGA tracking explicitly |
|
Date: |
Mon, 20 Apr 2015 15:54:52 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 20/04/2015 15:11, Stefan Hajnoczi wrote:
>> - memory_region_set_coalescing(&s->mem_vram); +
>> memory_region_set_log(&s->mem_vram, true, DIRTY_MEMORY_VGA);
>
> This change isn't 100% clear to me. I guess that coalescing
> (performance optimization) doesn't make sense when logging is
> enabled?
No, it's just that coalescing is for MMIO, not RAM. Setting
coalescing was a no-op. I'll make this a separate patch.
Paolo