[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/4] target-arm: kvm - support for single ste
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/4] target-arm: kvm - support for single step |
Date: |
Tue, 21 Apr 2015 14:01:50 +0100 |
On 21 April 2015 at 13:56, Alex Bennée <address@hidden> wrote:
>
> Peter Maydell <address@hidden> writes:
>>> switch (hsr_ec) {
>>> + case HSR_EC_SOFT_STEP:
>>> + if (cs->singlestep_enabled) {
>>> + return true;
>>> + } else {
>>> + error_report("Came out of SINGLE STEP when not enabled");
>>
>> This can only happen if there's a kernel bug, right?
>
> Sure. Should we report it differently? abort() out?
Saying 'This would be a kernel bug' in a comment would do...
-- PMM