[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/22] display: enable DIRTY_MEMORY_VGA tracking
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH 04/22] display: enable DIRTY_MEMORY_VGA tracking explicitly |
|
Date: |
Wed, 22 Apr 2015 10:12:02 +0100 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Apr 20, 2015 at 03:54:52PM +0200, Paolo Bonzini wrote:
>
>
> On 20/04/2015 15:11, Stefan Hajnoczi wrote:
> >> - memory_region_set_coalescing(&s->mem_vram); +
> >> memory_region_set_log(&s->mem_vram, true, DIRTY_MEMORY_VGA);
> >
> > This change isn't 100% clear to me. I guess that coalescing
> > (performance optimization) doesn't make sense when logging is
> > enabled?
>
> No, it's just that coalescing is for MMIO, not RAM. Setting
> coalescing was a no-op. I'll make this a separate patch.
Thanks!
pgplLoSQS_eBB.pgp
Description: PGP signature