qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 7/8] qemu-iotests: fix test_stream_partial()


From: Alberto Garcia
Subject: Re: [Qemu-devel] [PATCH 7/8] qemu-iotests: fix test_stream_partial()
Date: Wed, 22 Apr 2015 21:52:38 +0200
User-agent: Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu)

On Wed 22 Apr 2015 09:38:40 PM CEST, Eric Blake wrote:

> You know, we should _also_ test a no-op stream, to prove that we
> handle it correctly (we've had bugs in the past where 0-length active
> commit behaved differently in the events it generated than non-zero
> length), and your change is dropping that.

Well, we were checking that by accident :-)

But yes, I get the point. I can add that test if a further patch.

I also think that it would be a good idea to compare the actual contents
(using qemu-img compare) rather than the list of allocated areas, which
is what we're doing now.

But that would require a more substantial modification of the test case.

Berto



reply via email to

[Prev in Thread] Current Thread [Next in Thread]