Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

[Leon Alrae]

On 21/04/2015 19:08, Liviu Ionescu wrote:
> 
>> On 21 Apr 2015, at 16:34, Leon Alrae <address@hidden> wrote:
>>
>> I'll resend the patch with dropped "RFC" as I would really like to go
>> forward and finally close this issue.
> 
> perhaps you should first take a closer look at the patch I submitted, since 
> it covers not only parsing the arguments, but also grouping all semihosting 
> related variables in a structure and using them where needed.

Thanks for that patch. The issue I can see is that these changes could
have been broken into 3 separate patches: (1) add -semihosting-cmdline
option (2) convert to semihosting struct (3) improve the ARM
semihosting. I think during the discussion eventually we resigned from
adding top level -semihosting-cmdline option (1), but the other two
parts (2) and (3) probably are still valuable.

Please let me know if you want to extract (2) change and send it as a
separate patch (note that there were some suggestions regarding the
clean up on the other thread so probably syncing would be a good idea).
If not that's fine, since this is relatively small amount of changes I
can do that all in one shot while adding "arg=" suboption.

Thanks,
Leon