[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/10] s390x/kvm: Remove message about "switch_a
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCH 01/10] s390x/kvm: Remove message about "switch_amode" kernel parameter |
Date: |
Thu, 23 Apr 2015 14:26:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
Am 09.04.2015 um 10:51 schrieb Cornelia Huck:
> From: Thomas Huth <address@hidden>
>
> The "switch_amode" parameter has been removed from the Linux kernel
> sources since version 3.7 - so QEMU should not advise this parameter
> nowadays anymore.
>
> Signed-off-by: Thomas Huth <address@hidden>
> Acked-by: Cornelia Huck <address@hidden>
> Signed-off-by: Cornelia Huck <address@hidden>
> ---
> kvm-all.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index dd44f8c..7c8537b 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -1542,11 +1542,6 @@ static int kvm_init(MachineState *ms)
> if (ret < 0) {
> fprintf(stderr, "ioctl(KVM_CREATE_VM) failed: %d %s\n", -ret,
> strerror(-ret));
> -
> -#ifdef TARGET_S390X
> - fprintf(stderr, "Please add the 'switch_amode' kernel parameter to "
> - "your host kernel command line\n");
> -#endif
> goto err;
> }
>
Can you drop this patch from your upcoming pull request?
See the discussion on http://marc.info/?l=kvm&m=142978728714865&w=2
We might want to change the error message instead of getting rid of it.
Christian
- [Qemu-devel] [PATCH 00/10] first pile of s390x patches for 2.4, Cornelia Huck, 2015/04/09
- [Qemu-devel] [PATCH 02/10] virtio-ccw: sort into categories, Cornelia Huck, 2015/04/09
- [Qemu-devel] [PATCH 01/10] s390x/kvm: Remove message about "switch_amode" kernel parameter, Cornelia Huck, 2015/04/09
- Re: [Qemu-devel] [PATCH 01/10] s390x/kvm: Remove message about "switch_amode" kernel parameter,
Christian Borntraeger <=
- [Qemu-devel] [PATCH 04/10] sclp: sort into categories, Cornelia Huck, 2015/04/09
- [Qemu-devel] [PATCH 05/10] s390x/ipl: sort into categories, Cornelia Huck, 2015/04/09
- [Qemu-devel] [PATCH 03/10] s390-virtio: sort into categories, Cornelia Huck, 2015/04/09
- [Qemu-devel] [PATCH 06/10] s390x/mmu: Use access type definitions instead of magic values, Cornelia Huck, 2015/04/09
- [Qemu-devel] [PATCH 08/10] s390x/kvm: Put vm name, extended name and UUID into STSI322 SYSIB, Cornelia Huck, 2015/04/09
- [Qemu-devel] [PATCH 09/10] s390x/mmu: Use ioctl for reading and writing from/to guest memory, Cornelia Huck, 2015/04/09