[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qmp-commands.hx: Update the supported 'transact
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] qmp-commands.hx: Update the supported 'transaction' operations |
Date: |
Thu, 23 Apr 2015 17:07:44 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 04/23/2015 06:46 AM, Kashyap Chamarthy wrote:
> Although the canonical source of reference for QMP commands is
> qapi-schema.json, for consistency's sake, update qmp-commands.hx to
> state the list of supported transactionable operations, namely:
>
> drive-backup
> blockdev-backup
> blockdev-snapshot-internal-sync
> abort
> block-dirty-bitmap-add
> block-dirty-bitmap-clear
>
> NB: The 'block-dirty-bitmap-add' and 'block-dirty-bitmap-add' commands
> will be available once the in-review "transactionless incremental
> backup" patch series[1] is merged upstream.
>
> [1] http://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg02161.html
>
> Signed-off-by: Kashyap Chamarthy <address@hidden>
> ---
> qmp-commands.hx | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
>
> -Atomically operate on one or more block devices. The only supported
> operations
> -for now are drive-backup, internal and external snapshotting. A list of
> -dictionaries is accepted, that contains the actions to be performed.
> -If there is any failure performing any of the operations, all operations
> -for the group are abandoned.
> +Atomically operate on one or more block devices. Operations that are
> +currently supported: drive-backup, blockdev-backup,
> +blockdev-snapshot-sync, blockdev-snapshot-internal-sync, abort,
> +block-dirty-bitmap-add, block-dirty-bitmap-clear (refer
s/refer/refer to the/
> +qemu/qapi-schema.json file for minimum required QEMU versions for these
> +commands). A list of dictionaries is accepted, that contains the actions
> +to be performed. If there is any failure performing any of the
> +operations, all operations for the group are abandoned.
>
With that change,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature