[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH target-arm v4 07/16] net: cadence_gem: Clean up
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH target-arm v4 07/16] net: cadence_gem: Clean up variable names |
Date: |
Fri, 24 Apr 2015 09:51:07 -0700 |
On Thu, Apr 23, 2015 at 10:50 AM, Peter Maydell
<address@hidden> wrote:
> On 23 March 2015 at 11:05, Peter Crosthwaite
> <address@hidden> wrote:
>> In preparation for migrating the state struct and type cast macro to a public
I have also made this commit message more standalone.
>> header. The acronym "GEM" on it's own is not specific enough to be used in a
>> more global namespace so preface with "cadence". Fix the capitalisation of
>> "gem" in the state type while touching the typename. Also preface the
>> GEM_MAXREG macro as this will need to migrate to public header.
>>
>> Reviewed-by: Alistair Francis <address@hidden>
>> Reviewed-by: Alex Bennée <address@hidden>
>> Signed-off-by: Peter Crosthwaite <address@hidden>
>
> Reviewed-by: Peter Maydell <address@hidden>
>
Thanks.
Regards,
Peter
> thanks
> -- PMM
>