Re: [Qemu-devel] [PATCH v2] qmp-commands.hx: Update the supported 'transaction' operations

[Eric Blake]

On 04/24/2015 10:20 AM, Kashyap Chamarthy wrote:
> On Fri, Apr 24, 2015 at 11:52:00AM -0400, John Snow wrote:
>>
>> On 04/24/2015 04:32 AM, Kashyap Chamarthy wrote:
> 
> [. . .]
> 
>> These:
>>
>>>     block-dirty-bitmap-add
>>>     block-dirty-bitmap-clear
>>>
>>
>> Aren't merged yet, so it might be a little confusing.
> 
> Yeah, I expected someone to call that out, that's the reason I added the
> NB at the end of the commit message which explicitly states that these
> will be usable once your series (linked below) is merged, hoping that'd
> clarify.
> 
>> We could tack this on to the end of the transaction series if you'd
>> like, and hopefully that all goes in at once before 2.4.
> 
> That works too. 
> 
> If it's preferable, I can respin this to remove the mention of above two
> commands and resubmit a v3. 

I would have just added a note after the '---' line that the patch
depends on the transaction series going in first.  That is, basically
appending this on to the end of the transaction series is the best
approach for now, rather than trying to respin without the new commands.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature