[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 15/17] target-s390x: Extend arch specific QMP
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCH v5 15/17] target-s390x: Extend arch specific QMP command query-cpu-definitions |
Date: |
Mon, 27 Apr 2015 10:11:29 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
Am 13.04.2015 um 15:56 schrieb Michael Mueller:
> This patch implements the QMP command 'query-cpu-definitions' in the S390
> context. The command returns a list of cpu definitions in the current host
> context. A runnable and migratable cpu model has the related attributes
> set to true. The order attribute is used to bring the listed cpu definitions
> in a release order.
Can you add some explanation why we need the fallback code (e.g. something
along the line, when querying no KVM guest is available and to query the
capabilities we have to open a dummy VM bla bla)
[...]
> -static int kvm_s390_get_machine_props(KVMState *s, S390MachineProps *prop)
> +static int get_machine_props_fallback(S390MachineProps *prop)
> +{
> + struct kvm_device_attr dev_attr;
> + int rc, kvmfd = -1, vmfd = -1;
> +
> + rc = qemu_open("/dev/kvm", O_RDWR);
> + if (rc < 0) {
> + goto out_err;
> + }
> + kvmfd = rc;
> +
> + rc = ioctl(kvmfd, KVM_CREATE_VM, 0);
> + if (rc < 0) {
> + goto out_err;
> + }
> + vmfd = rc;
> +
> + rc = ioctl(vmfd, KVM_CHECK_EXTENSION, KVM_CAP_VM_ATTRIBUTES);
> + if (rc < 0) {
> + rc = -ENOSYS;
> + goto out_err;
> + }
> +
> + dev_attr.group = KVM_S390_VM_CPU_MODEL;
> + dev_attr.attr = KVM_S390_VM_CPU_MACHINE;
> + rc = ioctl(vmfd, KVM_HAS_DEVICE_ATTR, &dev_attr);
> + if (rc < 0) {
> + rc = -EFAULT;
> + goto out_err;
> + }
> +
> + dev_attr.addr = (uint64_t) prop;
> + rc = ioctl(vmfd, KVM_GET_DEVICE_ATTR, &dev_attr);
> +
> +out_err:
> + if (vmfd >= 0) {
> + close(vmfd);
> + }
> + if (kvmfd >= 0) {
> + close(kvmfd);
> + }
> +
> + return rc;
> +}
> +
> +int kvm_s390_get_machine_props(KVMState *s, S390MachineProps *prop)
> {
> int rc = -EFAULT;
>
> if (s) {
> rc = cpu_model_get(s, KVM_S390_VM_CPU_MACHINE, (uint64_t) prop);
> + } else {
> + rc = get_machine_props_fallback(prop);
> }
> trace_kvm_get_machine_props(rc, prop->cpuid, prop->ibc);
>
- Re: [Qemu-devel] [PATCH v5 11/17] target-s390x: Add KVM VM attribute interface for S390 CPU models, (continued)
- [Qemu-devel] [PATCH v5 08/17] target-s390x: Introduce S390 CPU models, Michael Mueller, 2015/04/13
- [Qemu-devel] [PATCH v5 10/17] target-s390x: Add S390 CPU model alias definition routines, Michael Mueller, 2015/04/13
- [Qemu-devel] [PATCH v5 17/17] target-s390x: Enable S390 CPU model usage, Michael Mueller, 2015/04/13
- [Qemu-devel] [PATCH v5 09/17] target-s390x: Define S390 CPU model specific facility lists, Michael Mueller, 2015/04/13
- [Qemu-devel] [PATCH v5 15/17] target-s390x: Extend arch specific QMP command query-cpu-definitions, Michael Mueller, 2015/04/13
- Re: [Qemu-devel] [PATCH v5 15/17] target-s390x: Extend arch specific QMP command query-cpu-definitions,
Christian Borntraeger <=
- [Qemu-devel] [PATCH v5 07/17] target-s390x: Generate facility defines per S390 CPU model, Michael Mueller, 2015/04/13
- [Qemu-devel] [PATCH v5 13/17] target-s390x: Prepare accelerator during S390 CPU object realization, Michael Mueller, 2015/04/13
- [Qemu-devel] [PATCH v5 12/17] target-s390x: Add S390 CPU class initialization routines, Michael Mueller, 2015/04/13
- Re: [Qemu-devel] [PATCH v5 00/17] s390x cpu model implementation, Christian Borntraeger, 2015/04/27