[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier
From: |
Eric Auger |
Subject: |
Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier |
Date: |
Mon, 27 Apr 2015 14:20:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 04/27/2015 12:39 PM, Paolo Bonzini wrote:
>
>
> On 27/04/2015 10:26, Eric Auger wrote:
>>>> One of my long term goals is to try and get rid of sysbus IRQ
>>>> abstraction completely in favor of just qdev gpios. This means
>>>> features that apply to GPIOs automatically apply to IRQs and vice
>>>> versa. Can your notifier hook be pushed up to the qdev GPIO level to
>>>> make it more globally usable and avoid a new feature to sysbus IRQs?
>> Yes sure, I am going to put the notifier in DeviceClass then.
>
> I've thought too about this, and I'm not sure about it.
>
> It would mean you have to pass the gpio name (e.g.
> SYSBUS_DEVICE_GPIO_IRQ) to the hook, and in the case of sysbus IRQs this
> would leak the SYSBUS_DEVICE_GPIO_IRQ abstraction to the implementors of
> the hook.
Hi Paolo,
Currently my notifier has the following proto:
void (*connect_gpio_out_notifier)(DeviceState *dev, qemu_irq irq);
It is sufficient for my need.
is it really mandated to pass other qdev_connect_gpio_out_named args,
ie. name & n?
Best Regards
Eric
>
> Paolo
>
- [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier, Eric Auger, 2015/04/24
- Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier, Peter Crosthwaite, 2015/04/27
- Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier, Eric Auger, 2015/04/27
- Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier, Paolo Bonzini, 2015/04/27
- Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier,
Eric Auger <=
- Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier, Paolo Bonzini, 2015/04/27
- Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier, Peter Crosthwaite, 2015/04/27
- Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier, Eric Auger, 2015/04/27
- Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier, Paolo Bonzini, 2015/04/27
- Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier, Peter Crosthwaite, 2015/04/27
- Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier, Eric Auger, 2015/04/28
- Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier, Peter Crosthwaite, 2015/04/28
- Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier, Eric Auger, 2015/04/28
- Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier, Paolo Bonzini, 2015/04/28