Re: [Qemu-devel] [PATCH V7 08/16] virtio: introduce bus specific queue limit

[Michael S. Tsirkin]

On Tue, Apr 28, 2015 at 02:13:20PM +0800, Jason Wang wrote:
> 
> 
> On Tue, Apr 28, 2015 at 1:13 PM, Michael S. Tsirkin <address@hidden> wrote:
> >On Tue, Apr 28, 2015 at 11:14:04AM +0800, Jason Wang wrote:
> >>     On Mon, Apr 27, 2015 at 7:05 PM, Michael S. Tsirkin
> >><address@hidden> wrote:
> >> >On Thu, Apr 23, 2015 at 02:21:41PM +0800, Jason Wang wrote:
> >> >> This patch introduces a bus specific queue limitation. It will be
> >> >> useful for increasing the limit for one of the bus without
> >>disturbing
> >> >> other buses.
> >> >> Cc: Michael S. Tsirkin <address@hidden>
> >> >> Cc: Alexander Graf <address@hidden>
> >> >> Cc: Richard Henderson <address@hidden>
> >> >> Cc: Cornelia Huck <address@hidden>
> >> >> Cc: Christian Borntraeger <address@hidden>
> >> >> Cc: Paolo Bonzini <address@hidden>
> >> >> Signed-off-by: Jason Wang <address@hidden>
> >> >> Reviewed-by: Cornelia Huck <address@hidden>
> >> >
> >> >Is this still needed if you drop the attempt to
> >> >keep the limit around for old machine types?
> >> If we agree to drop, we probably need transport specific macro.
> >
> >You mean just rename VIRTIO_PCI_QUEUE_MAX to VIRTIO_QUEUE_MAX?
> >Fine, why not.
> 
> I mean keeping VIRTIO_PCI_QUEUE_MAX for pci only and just increase pci
> limit. And introduce e.g VIRTIO_PCI_QUEUE_CCW for ccw and keep it as 64.
> Since to my understanding, it's not safe to increase the limit for all other
> transports which was pointed out by Cornelia in V1:
> http://permalink.gmane.org/gmane.comp.emulators.qemu/318245.

I think all you need is add a check to CCW_CMD_SET_IND:
limit to 64 for legacy interrupts only.

-- 
MST