[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] pci: Merge pci_nic_init() into pci_nic_init_nof
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] pci: Merge pci_nic_init() into pci_nic_init_nofail() |
|
Date: |
Tue, 28 Apr 2015 17:07:53 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Thomas Huth <address@hidden> writes:
> The error reporting in pci_nic_init() is quite erratic: Some errors
> are printed directly with error_report(), and some are passed back
> to the caller pci_nic_init_nofail() via an Error pointer.
> Since pci_nic_init() is only used by pci_nic_init_nofail(), the
> functions can be simply merged to clean up this inconsistency.
>
> Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>