qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] kvm: Silence warning from valgrind


From: Michael Tokarev
Subject: Re: [Qemu-devel] [PATCH] kvm: Silence warning from valgrind
Date: Wed, 29 Apr 2015 09:50:40 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0

29.04.2015 09:43, Thomas Huth wrote:
> On Wed, 29 Apr 2015 09:34:51 +0300
> Michael Tokarev <address@hidden> wrote:
[]
>> Hm.  So, what's the difference?  The same fields are assigned the same
>> values, why in first case we have some uninitialized data and in second
>> case everything is initialized?  Does struct initializer zero-fills all
>> other places (alignments, missing fields etc) ?
> 
> Right, the struct initializer fills the remaining fields with zeros.

Okay, point taken.  I just didn't know.

>> If yes, there's no need to assign zero to flags, btw ;)
> 
> True. Shall I sent a patch without that line?

I think it is better for readability to have it in.

Applied to -trivial, thank you!

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]