qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v13 10/12] qdev: check callback takes the proper


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v13 10/12] qdev: check callback takes the property child as third argument
Date: Wed, 29 Apr 2015 10:22:55 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0


On 28/04/2015 18:51, Eric Auger wrote:
> -    prop->check(obj, name, new_target, &local_err);
> +    object_ref(new_target);
> +    *child = new_target;
> +
> +    prop->check(obj, name, child, &local_err);
>      if (local_err) {
>          error_propagate(errp, local_err);
> +        *child = old_target;
> +        object_ref(new_target);

This should be an unref.

Paolo

>          return;
>      }
>  
> -    object_ref(new_target);
> -    *child = new_target;
>      object_unref(old_target);



reply via email to

[Prev in Thread] Current Thread [Next in Thread]