[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 4/4] scripts: qmp-shell: Add verbose flag
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 4/4] scripts: qmp-shell: Add verbose flag |
Date: |
Wed, 29 Apr 2015 13:35:44 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 04/29/2015 01:14 PM, John Snow wrote:
> Add a verbose flag that shows the QMP command that was
> constructed, to allow for later copy/pasting, reference,
> debugging, etc.
>
> The QMP is converted from a Python literal to JSON first,
> to ensure that it is viable input to the actual QMP parser.
>
> As a side-effect, this JSON output will helpfully show all
> the necessary conversions that were performed on the input,
> illustrating that "True" was transformed back into "true",
> literal values are now escaped with "" instead of '', and so on.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> scripts/qmp/qmp-shell | 24 ++++++++++++++++++------
> 1 file changed, 18 insertions(+), 6 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v4 0/4] scripts: qmp-shell: add transaction support, John Snow, 2015/04/29
- [Qemu-devel] [PATCH v4 1/4] scripts: qmp-shell: refactor helpers, John Snow, 2015/04/29
- [Qemu-devel] [PATCH v4 3/4] scripts: qmp-shell: add transaction subshell, John Snow, 2015/04/29
- [Qemu-devel] [PATCH v4 2/4] scripts: qmp-shell: Expand support for QMP expressions, John Snow, 2015/04/29
- [Qemu-devel] [PATCH v4 4/4] scripts: qmp-shell: Add verbose flag, John Snow, 2015/04/29
- Re: [Qemu-devel] [PATCH v4 4/4] scripts: qmp-shell: Add verbose flag,
Eric Blake <=
- Re: [Qemu-devel] [PATCH v4 0/4] scripts: qmp-shell: add transaction support, Kashyap Chamarthy, 2015/04/30