qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH 6/8] tap: Drop tap_can_send


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [RFC PATCH 6/8] tap: Drop tap_can_send
Date: Thu, 30 Apr 2015 12:32:25 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0


On 30/04/2015 10:59, Jason Wang wrote:
>>
>>  
>> +        /* If !can_send, we will want to disable the read poll, but
>> we still
>> +         * need the send completion callback to enable it again,
>> which is a
>> +         * sign of peer becoming ready.  So call the send function
>> +         * regardlessly of can_send.
>> +         */
> 
> It was probably not safe to depend on sent_cb to re-enable the polling.
> Since the packet could be purged in some conditions (e.g
> net_vm_change_state_handler()). So tap_send_completed won't be called in
> this case.

Doesn't qemu_net_queue_purge also call the sent_cb?

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]