Re: [Qemu-devel] [PATCH v2 3/4] qapi: Correctly handle downstream extensions in more locations

[Eric Blake]

On 04/29/2015 09:30 AM, Eric Blake wrote:
> On 04/29/2015 05:29 AM, Markus Armbruster wrote:
>> Eric Blake <address@hidden> writes:
>>
>>> Now that c_var() handles '.' in downstream extension names, fix
>>> the generator to support such names as additional types, enums,
>>> members within an enum, branches of a union or alternate, and
>>> in arrays.
>>>

>>>
>>>  def generate_visit_struct_fields(name, field_prefix, fn_prefix, members, 
>>> base = None):
>>> +    assert field_prefix == ""
>>
>> Makes me wonder why we have a field_prefix parameter.
>>
>> fn_prefix is also always ""...
> 
> Hmm - looks like I was debugging whether the code was dead (by whether I
> could trigger the assertion) and forgot to clean it up.  I'll split that
> into a separate patch (I've already done another related cleanup that I
> found while reviewing this code, in commit 6540e9f).

In fact, the code was NOT dead until I killed inline structs ("qapi:
Drop support for inline nested types").  Which means my cleanup wasn't
complete - but as that series is already at v7, I'll do the additional
cleanup as its own patch.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature