[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH 1/6] qcow2: use one single memory b
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH 1/6] qcow2: use one single memory block for the L2/refcount cache tables |
Date: |
Fri, 1 May 2015 15:23:21 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Apr 30, 2015 at 01:11:40PM +0300, Alberto Garcia wrote:
> Qcow2Cache *qcow2_cache_create(BlockDriverState *bs, int num_tables)
> {
> BDRVQcowState *s = bs->opaque;
> Qcow2Cache *c;
> - int i;
>
> c = g_new0(Qcow2Cache, 1);
> c->size = num_tables;
> + c->table_size = s->cluster_size;
This assumes c->table_size meets bs' memory alignment requirements. The
following would be safer:
c->table_size = QEMU_ALIGN_UP(c->table_size, bdrv_opt_mem_align(bs->file));
pgp9xyLpUYJUF.pgp
Description: PGP signature
- Re: [Qemu-devel] [Qemu-block] [PATCH 1/6] qcow2: use one single memory block for the L2/refcount cache tables,
Stefan Hajnoczi <=