qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Fwd: qemu drive mirror assert fault


From: Fam Zheng
Subject: Re: [Qemu-devel] Fwd: qemu drive mirror assert fault
Date: Tue, 5 May 2015 18:27:43 +0800
User-agent: Mutt/1.5.23 (2014-03-12)

On Tue, 05/05 12:13, Paolo Bonzini wrote:
> 
> 
> On 05/05/2015 09:36, Fam Zheng wrote:
> I don't think this commit is relevant.  The bug is caused by
> bdrv_co_discard clearing the bitmap (which is not supported during
> iteration, and is caught by the assertion).  That bdrv_reset_dirty is
> not removed by the commit you pointed out.

You are right, I think the bug is the bdrv_reset_dirty in bdrv_co_discard. The
discard may zero out the src area (depending on the backend), we should
probably replicate this to dest (actual data or the discard operation), rather
than forgetting the change.

Fam



reply via email to

[Prev in Thread] Current Thread [Next in Thread]