Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics

[Peter Maydell]

On 5 May 2015 at 05:45, Peter Crosthwaite <address@hidden> wrote:
> Add the ARM specific disassembly flags setup, so ARM can be correctly
> disassembled from the monitor.
>
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
>  monitor.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/monitor.c b/monitor.c
> index d831d98..9d9f1e2 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -1217,6 +1217,17 @@ static void memory_dump(Monitor *mon, int count, int 
> format, int wsize,
>          int flags;
>          flags = 0;
>          env = mon_get_cpu();
> +#ifdef TARGET_ARM
> +        if (env->thumb) {
> +            flags |= 1;
> +        }
> +        if (env->bswap_code) {
> +            flags |= 2;
> +        }
> +        if (env->aarch64) {
> +            flags |= 4;
> +        }
> +#endif

monitor.c has no business poking around in the CPU state
internals like this... You probably want a CPU method
get_disas_flags() or something.

-- PMM