qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] libcacard: stop including qemu-common.h


From: Michael Tokarev
Subject: Re: [Qemu-devel] [PATCH v2] libcacard: stop including qemu-common.h
Date: Wed, 06 May 2015 13:05:20 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0

06.05.2015 12:23, Laurent Desnogues wrote:
> Hello,
> 
> On Mon, Apr 27, 2015 at 3:27 PM, Michael Tokarev <address@hidden> wrote:
>> From: Paolo Bonzini <address@hidden>
>>
>> This is a small step towards making libcacard standalone.
> 
> on my system the removal of qemu-common.h inclusion broke compilation
> due to assert being used in glib-compat.h.

Interesting. What kind of build environment is that?  I compile-tested on
several platforms, all went fine.. ;)

>     A  fix might be to include
> assert.h in glib-compat.h.

I prefer s/assert/g_assert/ in glib-compat.h.

Thanks,

/mjt




reply via email to

[Prev in Thread] Current Thread [Next in Thread]