Re: [Qemu-devel] [PATCH 4/4] qemu-ga: Building Windows MSI installation with configure/Makefile

[Paolo Bonzini]

On 06/05/2015 13:53, Yossi Hindin wrote:
>>> > > +${QEMU_GA_MSI}: config-host.mak
>>> > > +
>>> > > +${QEMU_GA_MSI}:  qga/installer/qemu-ga.wxs
>>> > > +       $(call quiet-command,QEMU_GA_VERSION="$(QEMU_GA_VERSION)"
>>> > > QEMU_GA_MANUFACTURER="$(QEMU_GA_MANUFACTURER)"
>>> > > QEMU_GA_DISTRO="$(QEMU_GA_DISTRO)" \
>>> > > +       wixl -o $@ ${QEMU_GA_MSI_ARCH} ${QEMU_GA_MSI_WITH_VSS}
>>> > > ${QEMU_GA_MSI_MINGW_DLL_PATH} $<, "  WIXL  $@")
>> > 
>> > Please use $(...) instead of ${...} for consistency.
>   Fixed. BTW. there are other places  in the 'configure' script where ${} is 
> used.

Do you mean in the Makefile (or the generated .mak files)?

The configure script is a bash script, so it uses ${...} to access
variables.  The Makefile can use either ${...} or $(...), but the
parentheses are preferred over the braces.

Thanks,

Paolo