[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics |
Date: |
Wed, 06 May 2015 16:17:24 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 06/05/2015 16:12, Richard Henderson wrote:
>> Can
>> > we rely on the env/CPUState always being up to date during
>> > target_disas (which happens at translate time?) or will we need to go
>> > field by field to make sure any env updates explicitly occur before
>> > target_disas?
> I *think* so, but it's a near thing. The path goes
>
> tb_find_fast:
> cpu_get_tb_cpu_state, fill fill in flags for TB from current ENV state.
> tb_find_slow,
> tb_gen_code, using those same flags.
>
> There's the edge case of re-translation, but I'm going to assert that cpu mode
> changes ought not happen in that context. Doing otherwise means that the
> kernel has just switched modes, the translator has failed to end the TB, and
> the new code has faulted immediately.
>
> What I don't know is if we can, at the moment, canonicalize on TB flags. If
> the monitor were to use cpu_get_tb_cpu_state, I know it would work when using
> TCG, but I don't know if we keep all the same data up-to-date in KVM or XEN
> modes.
We do for KVM.
As far as I know, Xen doesn't have CPU state at all, not even in
fully-virtualized mode. The CPU state is held (and serialized during
migration) by the hypervisor.
Paolo
- Re: [Qemu-devel] [PATCH 5/7] disas: arm-a64: Make printfer and stream variable, (continued)
- [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics, Peter Crosthwaite, 2015/05/05
- Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics, Claudio Fontana, 2015/05/05
- Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics, Peter Maydell, 2015/05/05
- Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics, Peter Crosthwaite, 2015/05/06
- Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics, Richard Henderson, 2015/05/06
- Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics, Stefano Stabellini, 2015/05/06
- Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics, Peter Maydell, 2015/05/06
- Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics, Richard Henderson, 2015/05/06
- Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics, Peter Maydell, 2015/05/06
[Qemu-devel] [PATCH 7/7] disas: arm: Use target_disas impl for monitor, Peter Crosthwaite, 2015/05/05
Re: [Qemu-devel] [PATCH 0/7] disas: Unify target_disas and monitor_disas, Richard Henderson, 2015/05/05