[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 6/7] virtio-blk: Don't handle output when th
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH 6/7] virtio-blk: Don't handle output when there is "device IO" op blocker |
|
Date: |
Wed, 06 May 2015 16:18:22 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 06/05/2015 14:20, Fam Zheng wrote:
>> >
>> > Does non-dataplane need to do anything, since it uses iohandlers rather
>> > than aio_set_event_notifier_handler?
> I guess it's not for this specific bug. See this as an attempt on a general
> purpose "pause" mechanism to the device in investment for the future, for
> example, bdrv_aio_drain. ;-)
>
> I can drop it in v2 if you think the idea is not very helpful.
It's slightly more complicated but I think it's worth the extra coverage
testing that this provides.
Paolo
- [Qemu-devel] [RFC PATCH 3/7] block: Add op blocker notifier list, (continued)
- [Qemu-devel] [RFC PATCH 3/7] block: Add op blocker notifier list, Fam Zheng, 2015/05/06
- [Qemu-devel] [RFC PATCH 4/7] block-backend: Add blk_op_blocker_add_notifier, Fam Zheng, 2015/05/06
- [Qemu-devel] [RFC PATCH 2/7] block: Block "device IO" during bdrv_drain and bdrv_drain_all, Fam Zheng, 2015/05/06
- [Qemu-devel] [RFC PATCH 5/7] virtio-blk: Move complete_request to 'ops' structure, Fam Zheng, 2015/05/06
- [Qemu-devel] [RFC PATCH 7/7] blockdev: Add "device IO" op blocker during snapshot transaction, Fam Zheng, 2015/05/06
- [Qemu-devel] [RFC PATCH 6/7] virtio-blk: Don't handle output when there is "device IO" op blocker, Fam Zheng, 2015/05/06
- Re: [Qemu-devel] [Qemu-block] [RFC PATCH 0/7] Fix transactional snapshot with virtio-blk dataplane, Stefan Hajnoczi, 2015/05/07