[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 3/7] block: Add op blocker notifier list
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH 3/7] block: Add op blocker notifier list |
Date: |
Wed, 06 May 2015 16:22:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 06/05/2015 13:23, Fam Zheng wrote:
> void bdrv_op_block(BlockDriverState *bs, BlockOpType op, Error *reason)
> {
> BdrvOpBlocker *blocker;
> assert((int) op >= 0 && op < BLOCK_OP_TYPE_MAX);
>
> + bdrv_op_blocker_notify(bs, op, reason, true);
> blocker = g_new0(BdrvOpBlocker, 1);
> blocker->reason = reason;
> QLIST_INSERT_HEAD(&bs->op_blockers[op], blocker, list);
> @@ -3405,6 +3424,7 @@ void bdrv_op_unblock(BlockDriverState *bs, BlockOpType
> op, Error *reason)
> {
> BdrvOpBlocker *blocker, *next;
> assert((int) op >= 0 && op < BLOCK_OP_TYPE_MAX);
> + bdrv_op_blocker_notify(bs, op, reason, false);
> QLIST_FOREACH_SAFE(blocker, &bs->op_blockers[op], list, next) {
> if (blocker->reason == reason) {
> QLIST_REMOVE(blocker, list);
Changed in the following patch.
Also, should we only invoke the notifier if the list becomes
empty/non-empty? Is there any reason why the notifier would like to
know the particular Error that was added?
Paolo
- [Qemu-devel] [RFC PATCH 0/7] Fix transactional snapshot with virtio-blk dataplane, Fam Zheng, 2015/05/06
- [Qemu-devel] [RFC PATCH 1/7] block: Add op blocker type "device IO", Fam Zheng, 2015/05/06
- [Qemu-devel] [RFC PATCH 3/7] block: Add op blocker notifier list, Fam Zheng, 2015/05/06
- Re: [Qemu-devel] [RFC PATCH 3/7] block: Add op blocker notifier list,
Paolo Bonzini <=
- [Qemu-devel] [RFC PATCH 4/7] block-backend: Add blk_op_blocker_add_notifier, Fam Zheng, 2015/05/06
- [Qemu-devel] [RFC PATCH 2/7] block: Block "device IO" during bdrv_drain and bdrv_drain_all, Fam Zheng, 2015/05/06
- [Qemu-devel] [RFC PATCH 5/7] virtio-blk: Move complete_request to 'ops' structure, Fam Zheng, 2015/05/06
- [Qemu-devel] [RFC PATCH 7/7] blockdev: Add "device IO" op blocker during snapshot transaction, Fam Zheng, 2015/05/06
- [Qemu-devel] [RFC PATCH 6/7] virtio-blk: Don't handle output when there is "device IO" op blocker, Fam Zheng, 2015/05/06
- Re: [Qemu-devel] [Qemu-block] [RFC PATCH 0/7] Fix transactional snapshot with virtio-blk dataplane, Stefan Hajnoczi, 2015/05/07